frontend/src/components/custom-tools/manage-docs-modal/ManageDocsModal.jsx (1)

592-614: ⚠️ Potential issue | 🟡 Minor

Stale error message: "Only PDF files are allowed" is no longer accurate.

When ConfirmMultiDoc is not available and the file type isn't in DIRECT_UPLOAD_TYPES, the error message still says "Only PDF files are allowed" (Line 607). Now that CSV, TXT, and Excel files are also accepted, this message is misleading.

Proposed fix

           if (!ConfirmMultiDoc) {
             setAlertDetails({
               type: "error",
-              content: "Only PDF files are allowed",
+              content: "Only PDF, CSV, TXT, and Excel files are allowed",
             });
           }

backend/utils/file_storage/helpers/prompt_studio_file_helper.py (1)

178-201: ⚠️ Potential issue | 🟠 Major

Verify that text_content_string is always defined before Line 201.

If a file's MIME type is in allowed_content_types but doesn't match any of the explicit branches (PDF, text/plain, text/csv, Excel), execution reaches the else at Line 198, which only logs a warning. Control then falls to Line 201 where text_content_string is referenced — but it was never assigned, causing an UnboundLocalError.

This is a pre-existing issue, but the new branches make it more visible. Consider initializing text_content_string = "" before the if/elif chain or adding a return/raise in the else branch.

Proposed fix

     def fetch_file_contents(
         org_id: str,
         user_id: str,
         tool_id: str,
         file_name: str,
         allowed_content_types: list[str],
     ) -> dict[str, Any]:
         """Method to fetch file contents from the remote location.
         The path is constructed in runtime based on the args
         """
+        text_content_string: str = ""
         fs_instance = EnvHelper.get_storage(

backend/prompt_studio/prompt_studio_core_v2/views.py (1)

576-605: ⚠️ Potential issue | 🟡 Minor

Conversion failure will surface as an unhandled 500 error.

If process_file (Line 581) raises an exception (e.g., corrupted file, unsupported format variant), there's no try/except around the conversion block, so the entire upload request fails with a generic 500. Consider wrapping the conversion in a try/except and either falling back to storing the original without a converted preview, or returning a descriptive error message.

Proposed approach

             if file_converter_service.should_convert_to_pdf(file_type):
+                try:
                     converted_data, converted_name = file_converter_service.process_file(
                         uploaded_file, file_name
                     )
                     PromptStudioFileHelper.upload_converted_for_ide(
                         org_id=UserSessionUtils.get_organization_id(request),
                         user_id=custom_tool.created_by.user_id,
                         tool_id=str(custom_tool.tool_id),
                         file_name=converted_name,
                         file_data=converted_data,
                     )
+                except Exception:
+                    logger.warning(
+                        f"Failed to convert {file_name} to PDF for preview, "
+                        "storing original only"
+                    )
                 # Reset uploaded_file for storing original in main dir
                 uploaded_file.seek(0)
                 file_data = uploaded_file

frontend/src/components/custom-tools/document-manager/DocumentManager.jsx (1)

155-161: ⚠️ Potential issue | 🟠 Major

Bug: fileData is not reset when switching documents, causing stale mimeType.

When selectedDoc changes, fileUrl and extractTxt are reset but fileData (which holds mimeType) is not. This means between the reset and the new response arriving (or if the new request fails), the previous document's mimeType persists. Since isContentAvailable (line 482-485) and renderDoc (line 358) both depend on fileData.mimeType, stale state can cause incorrect rendering — e.g., showing the non-PDF placeholder for what should be a PDF, or marking content as available when the fetch actually failed.

Proposed fix

  useEffect(() => {
    setFileUrl("");
    setExtractTxt("");
+   setFileData({});
    Object.keys(viewTypes).forEach((item) => {
      handleFetchContent(viewTypes[item]);
    });
  }, [selectedDoc]);

Also reset in handleFetchContent:

  const handleFetchContent = (viewType) => {
    if (viewType === viewTypes.original) {
      setFileUrl("");
      setFileErrMsg("");
+     setFileData({});
    }

frontend/src/components/custom-tools/manage-docs-modal/ManageDocsModal.jsx (2)

610-615: ⚠️ Potential issue | 🟡 Minor

Update error message to reflect all allowed file types.

The error message "Only PDF files are allowed" is now inaccurate since CSV, TXT, and Excel files can also be uploaded directly. This will confuse users who attempt to upload unsupported formats.

📝 Proposed fix

           if (!ConfirmMultiDoc) {
             setAlertDetails({
               type: "error",
-              content: "Only PDF files are allowed",
+              content: "Only PDF, CSV, TXT, and Excel files are allowed",
             });
           }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@frontend/src/components/custom-tools/manage-docs-modal/ManageDocsModal.jsx`
around lines 610 - 615, The error message in ManageDocsModal.jsx currently set
when ConfirmMultiDoc is false is inaccurate; update the setAlertDetails call
(inside the ConfirmMultiDoc check) to use an accurate message listing the
allowed types (e.g., "Only PDF, CSV, TXT, and Excel files are allowed") or a
clear generic message like "Unsupported file type; allowed: PDF, CSV, TXT,
Excel" so users see the correct allowed formats; ensure you update the string
passed to setAlertDetails({ type: "error", content: ... }) where ConfirmMultiDoc
is evaluated.

---

608-621: ⚠️ Potential issue | 🔴 Critical

Backend serializer will reject CSV, TXT, and Excel uploads in OSS mode.

The frontend allows CSV, TXT, and Excel uploads via DIRECT_UPLOAD_TYPES, but the backend's FileUploadIdeSerializer validates against FileKey.FILE_UPLOAD_ALLOWED_EXT and FileKey.FILE_UPLOAD_ALLOWED_MIME. In OSS mode (without the file_converter plugin), these default to ["pdf"] and ["application/pdf"] respectively. Users will receive a serializer validation error when attempting these uploads, creating a mismatch between frontend allowlist and backend validation. The file_converter plugin gating only affects file conversion logic, not the initial upload validation.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@frontend/src/components/custom-tools/manage-docs-modal/ManageDocsModal.jsx`
around lines 608 - 621, Frontend permits CSV/TXT/Excel via DIRECT_UPLOAD_TYPES
but backend FileUploadIdeSerializer enforces
FileKey.FILE_UPLOAD_ALLOWED_EXT/MIME (OSS defaults to pdf), causing validation
failures; update the upload decision flow in ManageDocsModal.jsx to consult the
backend-supported upload types or the file_converter availability before
treating a file as "direct": either fetch allowed extensions/mimes from the
server (or read a passed-in prop/feature flag like isFileConverterEnabled) and
use that to compute DIRECT_UPLOAD_TYPES, or fall back to only allowing PDF as
direct upload; adjust the branch around DIRECT_UPLOAD_TYPES, setFileToUpload,
and resolve(file) so non-supported types show the ConfirmMultiDoc/error path
instead of resolving immediately.